Repository navigation
GH-66: [JDBC] Add test for closing a connection with a catalog twice - #1503
Merged
jbonofre merged 1 commit intoNov 19, 2026
Merged
Conversation
AbhishekPathania
requested review from
jbonofre,
laurentgo,
lidavidm and
wgtmac
as code owners
November 18, 2026 14:11
This comment has been minimized.
This comment has been minimized.
AbhishekPathania
marked this pull request as draft
November 18, 2026 14:15
AbhishekPathania
marked this pull request as ready for review
November 18, 2026 15:28
lidavidm
approved these changes
Nov 19, 2026
AbhishekPathania
force-pushed
the
gh-66-jdbc-idempotent-close
branch
from
November 19, 2026 10:10
0d5c552 to
ed0d38c
Compare
AbhishekPathania
force-pushed
the
gh-66-jdbc-idempotent-close
branch
from
November 19, 2026 12:11
ed0d38c to
026b736
Compare
jbonofre
approved these changes
Nov 19, 2026
jbonofre
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks @AbhishekPathania!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's Changed
Adds a regression test for #66: closing a connection that was opened with a
catalogtwice no longer throws, andCloseSessionreaches the server only once. The original failure is already fixed on main. #933 removed the duplicateArrowFlightSqlClientHandler#closecall, and the secondCloseSessionon the shut-down channel now fails withUNAVAILABLE, which #910 suppresses.MockFlightSqlProducernow implementscloseSessionso the test can count the calls.The test was drafted with an AI assistant (Claude). I reviewed it and checked that it passes on main.
Closes #66.